Solved Is there a way to make this code more efficient?

[KoenMaster05]

Hi everyone, I am very new to coding.
I made a skript for fortune to work on all blocks and so that they go in the player's inventory. The skript is working fine, but I was wondering If I can make the code more efficent, more compact.

I added the skript in a .txt file below
thanks!

 

[DrunkSheep73]

you can make a trader for example:
1 andesite --> 8 cobblestone
with the shopkeepers plugin

 

[KoenMaster05]

That's what I had first, but I wrote this skript to make it automatically turn into 8 cobblestone. The skript works just fine, I was just wondering if the code could be more compact.

 

[DrunkSheep73]

sorry, I don't know how

 

[lotzy]

That's what I had first, but I wrote this skript to make it automatically turn into 8 cobblestone. The skript works just fine, I was just wondering if the code could be more compact.

You can put all your multiplies into list like as set {list::%item%} to 5#multiplier
then:

Hi everyone, I am very new to coding.
I made a skript for fortune to work on all blocks and so that they go in the player's inventory. The skript is working fine, but I was wondering If I can make the code more efficent, more compact.

I added the skript in a .txt file below
thanks!

You can optimize/replace like that:

on load:
    set {-extendableDrop::stripped oak log} to 4 of oak log
    # ... all your's replacements

on mine:
    gamemode of player is survival
    if player's tool is enchanted with fortune
        set {_fortuneLevel} to level of fortune on player's tool + 1
        set {_fortuneMultiplier} to random integer between 1 and {_l}
    else:
        set {_fortuneMultiplier} to 1
    {-extendableDrop::%type of event-block%} is set
    clear drop
    set {_droppedItem} to {-extendableDrop::%type of event-block%}
    set {_droppedItem} to (item amount of {_droppedItem})*{_fortuneMultiplier} of {_droppedItem}
    if player have space for {_droppedItem}:
        give {_droppedItem} to player
    else:
        drop {_droppedItem} at event-block

 

[KoenMaster05]

You can put all your multiplies into list like as set {list::%item%} to 5#multiplier
then:

You can optimize/replace like that:

on load:
    set {-extendableDrop::stripped oak log} to 4 of oak log
    # ... all your's replacements

on mine:
    gamemode of player is survival
    if player's tool is enchanted with fortune
        set {_fortuneLevel} to level of fortune on player's tool + 1
        set {_fortuneMultiplier} to random integer between 1 and {_l}
    else:
        set {_fortuneMultiplier} to 1
    {-extendableDrop::%type of event-block%} is set
    clear drop
    set {_droppedItem} to {-extendableDrop::%type of event-block%}
    set {_droppedItem} to (item amount of {_droppedItem})*{_fortuneMultiplier} of {_droppedItem}
    if player have space for {_droppedItem}:
        give {_droppedItem} to player
    else:
        drop {_droppedItem} at event-block

Sorry for the late response, Do I need SkQuery or something for this to work? Because currently, it can't tell if type of event-block is in the extendableDrop options.

{-extendableDrop::%type of event-block%} is set

^
It can't understand that part