1. Welcome to skUnity!

    Welcome to skUnity! This is a forum where members of the Skript community can communicate and interact. Skript Resource Creators can post their Resources for all to see and use.

    If you haven't done so already, feel free to join our official Discord server to expand your level of interaction with the comminuty!

    Now, what are you waiting for? Join the community now!

Dismiss Notice
This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Hiring Temp Improving certain skript for $50.

Discussion in 'Hiring' started by sandor_1234, Apr 28, 2017.

  1. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222
    I read that variables are very buggy, they will be overwritten, if you got to many the whole variable file will reset.
    So is that a good idea?
     
  2. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222
    This never happened to me so chances are, it's the problem of someone who had this bug. If variables are being overwritten, it's likely that it's the code that's causing the variables to be overwritten.

    Trust me, variables are way more efficient and causes less problems than YML.
     
  3. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222
    Thank you for answering me,
    I could perhaps arrange your problem if you tell me why you do not use the faction (plugin)
     
  4. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222
    I don't get why people are so obsessed with using YML for storing variables.

    Saving and Reparsing YML data back into Skript takes considerably longer than using in-built variables.

    YML should only be used for configuration files that are only required once.

    If you really want to use YML, load all of your variables from YML once during start up, and save them back into the YML file once when the Skript reloads.


    Mate. That's called plagiarism. Something we don't condone. If there are "lots of faction like plugins out there", why don't you just use one of them?

    Edit: Also, the script is in a whole different language. We can't tell what the context to anything is.
    Code (Skript):
    1. set {_r2} to "Inwoner"
    Huh?
    Code (Skript):
    1.  
    2. send "{@prefix} &7Je moet &6Koning &7of &6Hertog &7zijn om dat te kunnen!"
    Wha?

    Code (Skript):
    1.  
    2. message "{@prefix} &7Je zit niet in een &6kingdom&7."
    3.  
    Yeah I can kinda make out that one. But not really.
     
    • Agree Agree x 2
    • Funny Funny x 1
  5. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222
    Because the faction plugin doesn't do exactly what i want it to do.
    Maybe yaml takes longer but will changing all yaml to variables remove the lagg?
    And when i worked with variables and i deleted them they wouldn't be deleted but just set to none or some thing like that.
    But if it keeps all these variables the variable file would become pretty big.

    And the language off the skript is Dutch i can understand that would be a small problem but you can try putting some thing you don't understand in google translate :emoji_stuck_out_tongue: .
    So (This is all translated by google translate):

    Inwoner = Resident
    Je moet Koning of Hertog zijn om dat te kunnen! = You must be King or Duke to be able to do that!
    Je zit niet in een kingdom = You are not in a kingdom

    Its not perfect but you will understand the meaning off it.

    So who can improve this skript (Remove the lag it creates) without losing the current data it created?
    (I can probably turn the yaml stuff into variables with a simple skript)
     
    #25 ShaneBee, Jun 5, 2017
    Last edited by a moderator: Jun 5, 2017
  6. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222
    Yes it will remove lag. And the variable file is "cleaned up" every time you reload skript so you should not have to worry about the file getting too large if you restart your server from time to time.
     
  7. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222
    Okay so now i am searching for some one who can do this job :emoji_grinning: .
    @Gatt Could you maybe do this?
    Or @Snow-Pyon do you already have a pc :emoji_slight_smile: ?
    I am still searching for people who can do the job.
    With "The job" i don't mean only changing the Yaml to variables but also bug fixes and improving other things.
     
  8. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222
    Just add a feature where if a player hasn't logged in a week the kingdom will be deleted.
     
  9. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222
    Bump
    --- Double Post Merged, Jun 8, 2017, Original Post Date: Jun 6, 2017 ---
    bump
     
  10. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222
    Yeah no. I haven't touched Skript in a whole year now, and I'd like to keep my fingers clean.
     
    • Winner Winner x 2
  11. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222
    I am still having this problem i did tons of research but still skript seems to be causing some lag but like you said there are also some other things and i doubt that the yaml is the real problem after allot off tests i did with it.

    I took a timings v2 report maybe some users can tell me some more about it:
    https://timings.aikar.co/?id=8c477937cf644ec4a0ccab2edb3911b3

    Thanks in advance <3
    --- Double Post Merged, Jun 23, 2017, Original Post Date: Jun 23, 2017 ---
    Could you improve the skript? Cuz i am still searching for some one who could do this.

    Also, i made this skript out off a early version from this skript:
    https://www.spigotmc.org/resources/clans-core-new-replacement-of-factions-skript.21708/
    If i would edit the newest version off that skript like i did with the other one will it fix all the lagg?
    His skript still uses yaml at first his skript used variables but he removed it for the reason the variables would be overwritten.
     
  12. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222

    The only fix right now can be upgrading your ram, as I see you have about 6gb and 80ish players online, so maybe try upgrading to 8gb and see if it still lags.
     
    • Agree Agree x 1
  13. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222
    But most of the time there is like 2 gb's of free memory with 80 players? So that wouldn't really help right.
    What is the:
    Skript::Event: ch.njol.skript.command.Commands$1 (PlayerCommandPreprocessEvent) ??
     
    #33 ShaneBee, Jun 24, 2017
    Last edited by a moderator: Jun 24, 2017
  14. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222
    ch.njol.skript.command.Commands is the commands you make with skript, and (PlayerCommandPreprocessEvent) is probably when a player executes that.. if not try it yourself and see. Maybe one of the commands you created has an error in it.
     
  15. ShaneBee

    Moderator Resource Staff Supporter + Addon Developer

    Joined:
    Sep 7, 2017
    Messages:
    2,184
    Likes Received:
    222
    Just want to let you know it was indeed the yaml stuff, i changed it all to variables and look at it now!!!
    https://timings.aikar.co/?id=b1ab20c531dd47a2a1a7633ab0686f86
    This is just proof to people who keep saying skript always causes lagg and you shouldn't use it etc, skript is as fast as you "Skript" it.

    Thanks a lot all of you for helping me :emoji_slight_smile: .
     
    #35 ShaneBee, Jul 1, 2017
    Last edited by a moderator: Jul 1, 2017
    • Like Like x 1
    • Friendly Friendly x 1

Share This Page

Loading...