How to make a system that removes a specific index of list and move all indexes after that down 1 step?

[DankThanos]

I am making a /changelog command and I am trying to make a remove system, by running the command /changelog remove 2 it should remove the 2nd row of the changelog and move the rows beneath it up one step. Although, the last row doesn't seem to correctly change position.

if i would have the changelog:

Changelog:
- change1
- change2
- change3
- change4

and do /changelog remove 2,
it should be:

Changelog
- change1
- change3
- change4

but instead, it becomes:

Changelog
- change1
- change3
- <none>
- change4

command /changelog [<string>] [<string>] [<string>]:
    executable by: players and console
    trigger:

    # other code

        else if arg 1 is "remove" or "delete" or "del":
            if player has permission "op":
                set {_changeIndex} to arg 2 parsed as integer
                set {_index} to size of {changelog::*}
                delete {changelog::%{_changeIndex}%}
                send "&aSuccessfully removed &echange %arg 2%" to event-player
                set {_changelogSize} to size of {changelog::*}
                set {_loopCount} to 0
                loop {_changelogSize} - {_changeIndex} + 1 times:
                    set {changelog::%{_changeIndex} + {_loopCount}%} to {changelog::%{_changeIndex} + {_loopCount} + 1%}
                    add 1 to {_loopCount}
                send {_changelogSize} to event-player
                send {changelog::%{_changelogSize}%} to event-player
                delete {changelog::%{_changelogSize}%}

 

[nenderson]

Hey! So what I think is wrong with your code: If you use add to add the changelogs it will start with 1
So it will set {changelog::0} which is not defined to {changelog::1} which is now overwritten to <none> it will continue that to the end so your last value will be <none> and should be all blank. I dont think I understand the whole issue yet as I cant really review a code that gives me vars when I cant see when/how it sets them.

I think if you replace this:

set {_loopCount} to 0
loop {_changelogSize} - {_changeIndex} + 1 times:
    set {changelog::%{_changeIndex} + {_loopCount}%} to {changelog::%{_changeIndex} + {_loopCount} + 1%}
    add 1 to {_loopCount}
    
(This is the broken code)

With the fix:

loop {changelog::*}:
    add {changelog::%loop-index%} to {changelogtemp::*}
clear {changelog::*}
set {changelogtemp::*} to {changelog::*}

It should work