Solved way to refresh menu

[Uzumaki]

right now i use

sub "sw.refreshmenu":   
    loop all players:   
        if inventory name of loop-player-1's current inventory is "{@arenasguiname}":
            set {_sw.list} to 0   
            loop {sw.arenas::*}:
                if {sw.arena.%loop-value-2%.status} is "{@ingame}" or "{@full}" or "{@restarting}":
                    make a gui slot {_sw.list} of loop-player-1 with red clay named "&8 " with lore "&8&l» &7Name&8: &e&l%loop-value-2%||||&8&l» &7Status&8: %{sw.arena.%loop-value-2%.status}%||||&8&l» &7Players&8: &7%{sw.arena.%loop-value-2%.playing}%/%{sw.arena.%loop-value-2%.max}%||||&8&l● &7&lClick to join!" to run loop-player-1 command "sw join %loop-value-2%"
                    add 1 to {_sw.list}
                else:
                    make a gui slot {_sw.list} of loop-player-1 with green clay named "&8 " with lore "&8&l» &7Name&8: &e&l%loop-value-2%||||&8&l» &7Status&8: %{sw.arena.%loop-value-2%.status}%||||&8&l» &7Players&8: &7%{sw.arena.%loop-value-2%.playing}%/%{sw.arena.%loop-value-2%.max}%||||&8&l● &7&lClick to join!" to run loop-player-1 command "sw join %loop-value-2%"                                         
                    add 1 to {_sw.list}
            stop

i wanna know if is a better way.

 

[Pikachu]

Why are you using subroutines in 2017?

 

[Uzumaki]

no, i use functions that was a example from my old skripts

 

[martinpeeters34]

Why are you using subroutines in 2017?

What's wrong with them, I'm still using them a lot those days. I just like them, I guess..

 

[Pikachu]

What's wrong with them, I'm still using them a lot those days. I just like them, I guess..

Because functions exist. I suppose nothing is wrong with them besides the fact you're needlessly relying on a abandoned addon