Potion effects on armour with lore

[Xetheralx]

Hi i run a small server with custom items and ive been trying to find a better way to to do this. At the moment i use loop to add effects to my items but its not ideal as its just adding the effect for 2 seconds all the time. here is an example of one of my scripts:

1. every 2 seconds:
2. loop all players:
3. #If the player we check is wearing a Gold helmet of Blast protection 5 and fire protection 3 and unbreaking 8 named "&c&lMiner's Helm" with the lore "&dThe Light Will Show The Way" and "&a-Gives Night Vision" and "&a-Ultra Durable"
4. if loop-player is wearing Gold helmet of Blast protection 5 and fire protection 3 and unbreaking 8 named "&c&lMiner's Helm" with lore "&dThe Light Will Show The Way" and "&a-Gives Night Vision" and "&a-Ultra Durable":
5. #then apply the Night vision 1 effect to that player for 2.5 seconds
6. apply Night vision to the loop-player for 2.5 seconds

I would like it if the effects would last indefinetly but only with the the piece of armour on and remove it when it is not equipped. I hope someone much smarter than i am can help me out with this! Thanks!

 

[sleepy unk]

on armor unequip:
    if event-item is gold helmet of blast protection 5 and fire protection 3 and unbreaking 8 named "&c&lMiner's Helm" with lore "&dLight will show the way!" and "&aGives night vision" and "&a- Ultra Durable":
        remove night vision from player


on armor equip:
    if event-item is gold helmet of blast protection 5 and fire protection 3 and unbreaking 8 named "&c&lMiner's Helm" with lore "&dLight will show the way!" and "&aGives night vision" and "&a- Ultra Durable":
        apply night vision to player for 99999 seconds

Here might help you. Much easier.
SOLVED