Solved Need help with a sign shop script.

[redstone_pro180]

I have a dupe server on 1.17.1 and i am trying to make it so players can buy items from a shop using coins earned by killing other players, everything works except the the script that gives you the bought item and subtracts the required coins.

on right click:
 block is a sign
 line 1 is "BUY"
 set {Cost} to line 2
 {Coins.%player%} is greater than {Cost} - 1
 set {Item} to line 3
 add {item} to player's inventory
 subtract {Cost} from {Coins.%player%}
 message "<green>bought %{item}%!"

How can i make this work?

 

[BanditEagle]

You should use {Coins::%player%} instead of {Coins.%player%} as having a list works better rather than creating a new variable for each person. Keeping this in mind, this should work:

on right click:
 block is a sign
 line 1 is "BUY"
 set {Cost} to line 2
 if {Coins::%player%} >= ({Cost} - 1):
  set {Item} to line 3
  add {item} to player's inventory
  set {Coins::%player%} to ({Coins::%player%} - {Cost})
  send "<green>bought %{item}%!" to player
 else:
  send "&cError: not enough coins" to player