Solved Fixing Effect Chance?

[JustADev]

BUG: The chance for Poison almost always happens, Even though its at 5% Chance,

CODE:

on damage:
        if {Poison::%attacker%} is more than 0:
                set {_Poisona} to 0.2 * {Poison::%attacker%}
                add 2 to {_Poisona}
                chance of 5%
        if {Poison_cooldown::%victim%} is not set:
                apply potion of poison 2 to victim for "%{_Poisona}% seconds" parsed as a timespan
                set {Poison_cooldown::%victim%} to now
        if difference between {Poison_cooldown::%victim%} and now is greater than 10 seconds:
                apply potion of poison 2 to victim for "%{_Poisona}% seconds" parsed as a timespan
                set {Poison_cooldown::%victim%} to now

 

[Deleted member 5254]

you could try using a different expression maybe. I haven't noticed any trouble with this way:

set {_test} to a random integer between 1 and 100
if {_test} is between 1 and 5:
    apply potion of poison 2 to victim for 5 seconds

 

[Deleted member 5254]

Eh but the thing is, I am doing a lvling system where you upgrade perks, so that wouldnt really work

 

[Deleted member 5254]

Eh but the thing is, I am doing a lvling system where you upgrade perks, so that wouldnt really work

Ah I see. No idea how to fix the bug, unfortunately:c

 

[Deleted member 5254]

BUG: The chance for Poison almost always happens, Even though its at 5% Chance,

CODE:

on damage:
        if {Poison::%attacker%} is more than 0:
                set {_Poisona} to 0.2 * {Poison::%attacker%}
                add 2 to {_Poisona}
                chance of 5%
        if {Poison_cooldown::%victim%} is not set:
                apply potion of poison 2 to victim for "%{_Poisona}% seconds" parsed as a timespan
                set {Poison_cooldown::%victim%} to now
        if difference between {Poison_cooldown::%victim%} and now is greater than 10 seconds:
                apply potion of poison 2 to victim for "%{_Poisona}% seconds" parsed as a timespan
                set {Poison_cooldown::%victim%} to now

Your using it wrong, just putting it at the end doesn't magically make it work

@Wynnevir

if random integer from 1 to 100 is between 1 and 5

 

[Deleted member 5254]

wat do i do

 

[Deleted member 5254]

wat do i do

Oh he's right. Rude, but right.
Chance of 5%:
#do things

 

[Deleted member 5254]

OMG You are an angel among many! TYSM, IDK what I would do without you people tysm again

 

[Deleted member 5254]

OMG You are an angel among many! TYSM, IDK what I would do without you people tysm again

<33 I really do love just how helpful this forum is too. best place best peoples

 

[Deleted member 5254]

Do I need to move Chance of 5: up further?

        if {Poison::%attacker%} is more than 0:
                set {_Poisona} to 0.2 * {Poison::%attacker%}
                add 2 to {_Poisona}
                chance of 5%:
        if {Poison_cooldown::%victim%} is not set:
                apply potion of poison 2 to victim for "%{_Poisona}% seconds" parsed as a timespan
                set {Poison_cooldown::%victim%} to now
        if difference between {Poison_cooldown::%victim%} and now is greater than 10 seconds:
                apply potion of poison 2 to victim for "%{_Poisona}% seconds" parsed as a timespan
                set {Poison_cooldown::%victim%} to now

It still occurs frequently, but a lot less than b4

 

[Deleted member 5254]

Do I need to move Chance of 5: up further?

        if {Poison::%attacker%} is more than 0:
                set {_Poisona} to 0.2 * {Poison::%attacker%}
                add 2 to {_Poisona}
                chance of 5%:
        if {Poison_cooldown::%victim%} is not set:
                apply potion of poison 2 to victim for "%{_Poisona}% seconds" parsed as a timespan
                set {Poison_cooldown::%victim%} to now
        if difference between {Poison_cooldown::%victim%} and now is greater than 10 seconds:
                apply potion of poison 2 to victim for "%{_Poisona}% seconds" parsed as a timespan
                set {Poison_cooldown::%victim%} to now

It still occurs frequently, but a lot less than b4

Yes, it needs to go before everything you want it to do just like an "if" statement. and the effects after it pertaining to it gets tabbed once

 

[Deleted member 5254]

So can you show me where I should put it?

 

[Deleted member 5254]

I'm assuming it should only apply to your 1 if statement there above it so like this:

chance of 5%:
    if {Poison::%attacker%} is more than 0:
        set {_Poisona} to 0.2 * {Poison::%attacker%}
        add 2 to {_Poisona}

[doublepost=1501372528,1501372446][/doublepost]or this way if you want it to check that variable first

if {Poison::%attacker%} is more than 0:
    chance of 5%:
        set {_Poisona} to 0.2 * {Poison::%attacker%}
        add 2 to {_Poisona}