Script [Deleted] Secret Bookshelf

[Deleted member 5254]

ShaneBolenback submitted a new resource:

Secret Bookshelf - Secret place to hide your stuff

A fun tool, to allow your players to hide items in a secret spot. Players can easily craft a secret bookshelf, place it wherever they need to, and have storage that is unknown to others.

Dependencies:
Skript (Tested on Bensku 2.2 dev34)
SkQuery

Spoiler: Crafting

...

Read more about this resource...

 

[Snow-Pyon]

It's a good script so far, I'll just point out some bad things I noticed while reviewing this script:

• Not using list variables; you should never use {this.format} in variables, less if you have something dynamic on it (such as %player%). The preferred format is {script-name::optional-category::%object%::optional-property}, in your case it would be {secretshelf::%player's uuid%}
• Checking against the event-location in the right click event, this isn't that bad but it could differ from the location you've saved, you're better off comparing it with the event-block's location.

 

[Deleted member 5254]

It's a good script so far, I'll just point out some bad things I noticed while reviewing this script:

• Not using list variables; you should never use {this.format} in variables, less if you have something dynamic on it (such as %player%). The preferred format is {script-name:ptional-category::%object%:ptional-property}, in your case it would be {secretshelf::%player's uuid%}
• Checking against the event-location in the right click event, this isn't that bad but it could differ from the location you've saved, you're better off comparing it with the event-block's location.

Thanks snow. I appreciate the feedback and guidance. I’ll definitenly take a look at cleaning it up, and going with your advice.