Solved Trouble with optimizing skript

[Doodle]

I was trying to simplify my skript since it took up 75 lines, and I was making progress until I got stumped. I don't know what to do in this situation:

else:
    set {_amount} to min(arg-1, 6)
    loop {_amount} times:
        add player's tool to player's inventory
    if {_amount} is 1:
        send action bar "&aSuccessfully duped item." to player
    else:
        send action bar "&aSuccessfully duped %{_amount}% items." to player
    if player has permission "everyitem.invest.dupe":
        remove 100$ from player's balance
    else:
        remove 250$ from player's balance

If you don't see the problem, there are two if:'s on the same indent. Is there any work-around, or is the code fine like this? Please let me know.

 

[Luke_Sky_Walker]

I was trying to simplify my skript since it took up 75 lines, and I was making progress until I got stumped. I don't know what to do in this situation:

else:
    set {_amount} to min(arg-1, 6)
    loop {_amount} times:
        add player's tool to player's inventory
    if {_amount} is 1:
        send action bar "&aSuccessfully duped item." to player
    else:
        send action bar "&aSuccessfully duped %{_amount}% items." to player
    if player has permission "everyitem.invest.dupe":
        remove 100$ from player's balance
    else:
        remove 250$ from player's balance

If you don't see the problem, there are two if:'s on the same indent. Is there any work-around, or is the code fine like this? Please let me know.

You can use ‘else if’ statements. I think that could make your code a bit more effective.

 

[Doodle]

You can use ‘else if’ statements. I think that could make your code a bit more effective.

See, that's the problem. It's two different lines of code that both do different things. If I were to use an else if: statement, it could potentially prevent some of my code from running.

 

[Luke_Sky_Walker]

See, that's the problem. It's two different lines of code that both do different things. If I were to use an else if: statement, it could potentially prevent some of my code from running.

function checkperm(p: player):
   if {_p} has permission "every item.invest.dupe":
      remove 100 from {_p}'s balance
  else:
      remove 250 from {_p}'s balance

Maybe you can use this function and call it before any if and else statement below your first else statement, ie:

else:
   checkperm(player)

# The rest of your code here

 

[Doodle]

function checkperm(p: player):
   if {_p} has permission "every item.invest.dupe":
      remove 100 from {_p}'s balance
  else:
      remove 250 from {_p}'s balance

Maybe you can use this function and call it before any if and else statement below your first else statement, ie:

else:
   checkperm(player)

# The rest of your code here

Hypothetically, could I write it like this:

checkperm(player)
if {_amount} is 1:
    send action bar "text bc I'm too lazy to write" to player
else:
    send action bar "more useless text" to player

 

[Luke_Sky_Walker]

Hypothetically, could I write it like this:

checkperm(player)
if {_amount} is 1:
    send action bar "text bc I'm too lazy to write" to player
else:
    send action bar "more useless text" to player

Yeah

 

[Doodle]

Yeah

Damn, I didn't know functions were this useful. Thanks a lot!

 

[Luke_Sky_Walker]

Damn, I didn't know functions were this useful. Thanks a lot!

No problem. And yeah, functions are awesome

 

[Doodle]

No problem. And yeah, functions are awesome

Another thing, where would I write the function? Near the beginning of my code, or when the command is ran?

 

[Luke_Sky_Walker]

Another thing, where would I write the function? Near the beginning of my code, or when the command is ran?

I honestly don’t think it matters but I personally put it before the code for organization, haha.

 

[Doodle]

I honestly don’t think it matters but I personally put it before the code for organization, haha.

Oh. Well, thanks a ton.

 

[Luke_Sky_Walker]

No prob, I’m glad I was able to help.

 

[Doodle]

I just realized I could have just used the word stop after the first 'else:' condition, but you gave me the motivation to learn more about functions and really helped me with making my code more efficient and keeping it simple at the same time. Thanks!