Soulbound no drop on death! Help!

[Lukkeeh]

on death of a player:
loop drops:
if lore of loop-item contains "&cSoulbound":
remove loop-item from drops

on respawn:
???


So i want to make that if an item got soulbound it wont drop and u will get it back on respawn. but i can only make it so it wont drop. i cant make it so i get it back on respawn. anyone that can help me ?

 

[Deleted member 5254]

else:
    stop

I really wish you guys would stop abusing "stop" and learn how to correctly use it, you can literally remove the "else" and "stop" since they do LITERALLY nothing.

on death of a player:
loop drops:
if lore of loop-item contains "&cSoulbound":
remove loop-item from drops

on respawn:
???


So i want to make that if an item got soulbound it wont drop and u will get it back on respawn. but i can only make it so it wont drop. i cant make it so i get it back on respawn. anyone that can help me ?

the best way to do it, is add the item to a list variable specific to the player, and when they respawn, give the item back to the player like so:
(I have tested this, and it works

on death of player:
    loop drops:
        if lore of loop-item contains "&cSoulbound":
            add loop-item to {soulbound::%uuid of player%::*}
            remove loop-item from drops
 
on respawn:
    loop {soulbound::%uuid of player%::*}:
        give loop-value to player
    delete {soulbound::%uuid of player%::*}

 

[Deleted member 5254]

I will never stop using stop, since I pretty much have been taught to always return even on a void function (Even if the teacher was wrong or not it works)

Correct me if I'm wrong but the stop is the same as return in Skript I believe

Yes its basically the same thing. But in Skript it just looks god awful.
Also, in Java you dont return a void if theres no need, so the same thing for Skript, no need to return or "stop" your code from doing nothing

Ex: in java

private void removePlayersTool(Player player) {
    if (player.getInventory().getItemInMainHand() != null) {
        player.getInventory().setItemInMainHand(null);
    }
}

in this example, I wouldnt return in an else statement, its just pointless since Java basically takes care of that for you.

Its the same in Skript, you dont need to return/stop "nothing" from happening

 

[TPGamesNL]

I will never stop using stop, since I pretty much have been taught to always return even on a void function (Even if the teacher was wrong or not it works)

Correct me if I'm wrong but the stop is the same as return in Skript I believe

If you think you should always return in Skript, then you shouldn't have put the stop effect in the the else section, because if the condition is true, it wouldn't return (the else section wouldn't be ran). If you should always return in Skript, you should've also added the stop in the first trigger, but ya didn't. And as Shane said, you don't have to (and shouldn't) do it in Skript, since it's completely useless.

 

[TPGamesNL]

Ok that's pretty cute text and all but "and shouldn't" and "it's completely useless" don't seem to mix

If something is useless, you shouldn't do it. Is that not clear?

 

[Lukkeeh]

on death of player:
    loop drops:
        if lore of loop-item contains "&cSoulbound":
        remove loop-item from drops
        set {SOULBOUND::%player%} to true

on respawn:
    if {SOULBOUND::%player%} is true:
        give whatever-item named "Soulbound" to player
        set {SOULBOUND::%player%} to false
    else:
        stop

Thanks!