Solved Not saving kills

[zainmz]

Skript Version (do not put latest): Skript bensku-2.5-alpha3
Skript Author: Bensku
Minecraft Version: 1.15.2
---
Full Code:

on death:
    if world is "world":
        message "&0[&aNOTICE&0]&b You have killed &e%player% &b" to the attacker
        attacker is a player
        add player to {records::%attacker%}
command /track [<player>]:
     if arg 1 is set:
         message " &b%arg-1% has killed &f%{records::%arg-1%}%"

There are no errors, however the problem im facing is that the kills are not getting saved to the list.

The aim of what I am trying to achieve is:
- list of all players killed by a player

 

[Dave]

Skript Version (do not put latest): Skript bensku-2.5-alpha3
Skript Author: Bensku
Minecraft Version: 1.15.2
---
Full Code:

on death:
    if world is "world":
        message "&0[&aNOTICE&0]&b You have killed &e%player% &b" to the attacker
        attacker is a player
        add player to {records::%attacker%}
command /track [<player>]:
     if arg 1 is set:
         message " &b%arg-1% has killed &f%{records::%arg-1%}%"

There are no errors, however the problem im facing is that the kills are not getting saved to the list.

The aim of what I am trying to achieve is:
- list of all players killed by a player

Everything's wrong in your code

Try this

#    Victim's combat-tag
on damage of a player:
    if attacker is a player:
        if victim is a player:
            set {lastAttacker.%victim%} to attacker
            wait 30 seconds
            delete {lastAttacker.%victim%}

#    Player death event
on death of a player:
    if {lastAttacker.%victim%} is set:
        if world is "world":
            send "&0[&aNOTICE&0]&b You have killed &e%victim%&b." to {lastAttacker.%victim%}
            add victim to {records::%{lastAttacker.%victim%}%}
            delete {lastAttacker.%victim%}

#   This prevents player from quitting while has combat-tag
on quit:
    if {lastAttacker.%player%} is set:
        message "&0[&aNOTICE&0]&b You have killed &e%player%&b because the player logged out in combat." to {lastAttacker.%victim%}
        add player to {records::%{lastAttacker.%player%}%}
        delete {lastAttacker.%player%}

command /track [<offline player>]:
    usage: /track <player>
    trigger:
        if arg 1 is set:
            if (size of {records::%arg-1%}) > 0:
                set {kills-on-record.%arg-1%} to "%{records::%arg-1%}%"

                replace every " and " with "&b, &f" in {kills-on-record.%arg-1%}
                replace every ", " with "&b, " in {kills-on-record.%arg-1%}
                replace every "<none>" with "" in {kills-on-record.%arg-1%}

                send "&b%arg-1% has killed &f%{kills-on-record.%arg-1%}%&b."
                delete {kills-on-record.%arg-1%}
            else:
                send "&cThis player has no kills on record."
        else:
            send "&cUsage: /track <player>"

Please, mark this as best answer if it works

 

[zainmz]

@Dave

Line 6: An entity cannot be saved, i.e. the contents of the variable {lastAttacker.%the attacked entity%} will be lost when the server stops. (script.sk, line 6: set {lastAttacker.%victim%} to attacker')

Line 21: The expression 'victim' can only be used in a damage or death event (script.sk, line 21: message "&0[&aNOTICE&0]&b You have killed &e%player%&b because the player logged out in combat." to {lastAttacker.%victim%}')

Line 29: '{records::%the 1st argument%}' can only ever have one value at most, thus the 'amount of ...' expression is useless. Use '... exists' instead to find out whether the expression has a value. (script.sk, line 29: if (size of {records::%arg-1%}) > 0:')

Line 38: 'else' has to be placed just after an 'if' or 'else if' section (line 38: else:') (Double check the "if"/"else if" section above the "else" as if it's wrong, then it causes this error. )

 

[Dave]

@Dave

Line 6: An entity cannot be saved, i.e. the contents of the variable {lastAttacker.%the attacked entity%} will be lost when the server stops. (script.sk, line 6: set {lastAttacker.%victim%} to attacker')

Line 21: The expression 'victim' can only be used in a damage or death event (script.sk, line 21: message "&0[&aNOTICE&0]&b You have killed &e%player%&b because the player logged out in combat." to {lastAttacker.%victim%}')

Line 29: '{records::%the 1st argument%}' can only ever have one value at most, thus the 'amount of ...' expression is useless. Use '... exists' instead to find out whether the expression has a value. (script.sk, line 29: if (size of {records::%arg-1%}) > 0:')

Line 38: 'else' has to be placed just after an 'if' or 'else if' section (line 38: else:') (Double check the "if"/"else if" section above the "else" as if it's wrong, then it causes this error. )

I fixed it. Code: https://pastebin.com/raw/ZMcmds15

#    Victim's combat-tag
on damage of a player:
    if attacker is a player:
        if victim is a player:
            set {_lastAttacker.%victim%} to attacker
            wait 30 seconds
            delete {_lastAttacker.%victim%}

#    Player death event
on death of a player:
    loop all players:
        if victim is player:
            if {_lastAttacker.%player%} is loop-player:
                send "&0[&aNOTICE&0]&b You have killed &e%player%&b." to {_lastAttacker.%player%}
                add player to {records.%{_lastAttacker.%player%}%::*}
                delete {_lastAttacker.%player%}

#   This prevents player from quitting while has combat-tag
on quit:
    if {_lastAttacker.%player%} is set:
        message "&0[&aNOTICE&0]&b You have killed &e%player%&b because the player logged out in combat." to {_lastAttacker.%player%}
        add player to {records.%{_lastAttacker.%player%}%::*}
        delete {_lastAttacker.%player%}

#    Get the kills on record
command /track [<offline player>]:
    usage: /track <player>
    trigger:
        if arg-1 is set:
            if (size of {records.%arg-1%::*}) > 0:
                set {kills-on-record.%arg-1%} to "%{records.%arg-1%::*}%"

                replace every " and " with "&b, &f" in {kills-on-record.%arg-1%}
                replace every ", " with "&b, " in {kills-on-record.%arg-1%}
                replace every "<none>" with "" in {kills-on-record.%arg-1%}

                send "&b%arg-1% has killed &f%{kills-on-record.%arg-1%}%&b."
                delete {kills-on-record.%arg-1%}
            else:
                send "&cThis player has no kills on record."
        else:
            send "&cUsage: /track <player>"

 

[zainmz]

Sadly it does not work, the list does not save players to it, the tracking always return no kills on record.

 

[Dave]

Sadly it does not work, the list does not save players to it, the tracking always return no kills on record.

can u addme on discord? Dave_#1544 i'll fix for u bro

 

[zainmz]

can u addme on discord? Dave_#1544 i'll fix for u bro

sent