Solved Making a deathnote

[SoMuchWessel]

Hello guys,

I am making a deathnote in minecraft, but i ran into a problem.

command /deathnote <player>:
    trigger:
        if arg-1 is set:
            if player is holding a enchanted book named "&cDeathnote":
                kill arg-1
                remove 1 enchanted book named "&cDeathnote" from the player
                broadcast "&c&l%player% killed %arg-1%!"
            else:
                send "&aYou are not holding a deathnote!"

This is the code i use. Imagine there is a player online named Jeb, and i do: /deathnote b, then jeb gets killed. But thats not what i want.
I want that only if i type /deathnote Jeb that it will kill him.


Can you guys help me?

 

[Wynnevir]

loop the players online and set a condition of arg 1 is equal to the loop-player. That way the arg has to be a full player name for it to kill them.

 

[SoMuchWessel]

loop the players online and set a condition of arg 1 is equal to the loop-player. That way the arg has to be a full player name for it to kill them.

Like this?

command /deathnote <player>:
    trigger:
        if arg-1 is set:
            if player is holding a enchanted book named "&cDeathnote":
                loop all players:
                    if loop-player = arg-1:
                        kill loop-player
                remove 1 enchanted book named "&cDeathnote" from the player
                broadcast "&c&l%player% killed %arg-1%!"
            else:
                send "&aYou are not holding a deathnote!"

 

[Wynnevir]

Like this?

command /deathnote <player>:
    trigger:
        if arg-1 is set:
            if player is holding a enchanted book named "&cDeathnote":
                loop all players:
                    if loop-player = arg-1:
                        kill loop-player
                remove 1 enchanted book named "&cDeathnote" from the player
                broadcast "&c&l%player% killed %arg-1%!"
            else:
                send "&aYou are not holding a deathnote!"

Yep, thats the idea! did it work for you?^-^

 

[SoMuchWessel]

Yep, thats the idea! did it work for you?^-^

Sadly not :c

 

[White]

What doesn't work? Also, try doing,

if loop-player is arg-player:

 

[SoMuchWessel]

What doesn't work? Also, try doing,

if loop-player is arg-player:

This kinda works, but still if i do /deathnote b it kills the player Jeb
'

Edit:
I came to this conclusion:

If i do: /deathnote b, and Jeb is online, it kills jeb because the name jeb contains the letter b,
So how do i fix that it only works when i type the full player name instead of just a letter

 

[Donut]

https://bensku.github.io/Skript/classes.html#player
"You have two possibilities to use players as command arguments: <player> and <offline player>. The first requires that the player is online and also accepts only part of the name, while the latter doesn't require that the player is online, but the player's name has to be entered exactly"

use offline player and check if theyre online

 

[SoMuchWessel]

https://bensku.github.io/Skript/classes.html#player
"You have two possibilities to use players as command arguments: <player> and <offline player>. The first requires that the player is online and also accepts only part of the name, while the latter doesn't require that the player is online, but the player's name has to be entered exactly"

use offline player and check if theyre online

I tried but i still got the same problem.

command /deathnote <offline player>:
    trigger:
        if arg-1 is not set:
            send "&a/deathnote <Player>"
        else:
            if player is holding a enchanted book named "&cDeathnote":
                if arg-1 is online:
                    kill arg-1
                    remove 1 enchanted book named "&cDeathnote" from the player
                    broadcast "&c&l%player% killed %arg-1%!"
                else:
                    send "%arg-1% is not online!"
            else:
                send "&aYou are not holding a deathnote!"

 

[Donut]

thats annoying, i guess youll have to do it like this

command /deathnote <text>:
    loop all players:
        if "%loop-value%" is arg-1:
            send "online!"

 

[SoMuchWessel]

thats annoying, i guess youll have to do it like this

command /deathnote <text>:
    loop all players:
        if "%loop-value%" is arg-1:
            send "online!"

I now got this:

command /deathnote <text>:
    trigger:
        if arg-1 is not set:
            send "&a/deathnote <Player>"
        else:
            if player is holding a enchanted book named "&cDeathnote":
                loop all players:
                    if "%loop-value%" is arg-1:
                        kill arg-1
                        remove 1 enchanted book named "&cDeathnote" from the player
                        broadcast "&c&l%player% killed %arg-1%!"
            else:
                send "&aYou are not holding a deathnote!"

But it now gives this error:
The 1st argument is not an entity (kill arg-1)

How do i solve this ?

 

[Donut]

kill arg-1 parsed as a player

 

[SoMuchWessel]

kill arg-1 parsed as a player

Thanks!
It works now