Solved every 2 seconds more elegant

[JuliHatSpaB]

I want to let the Block in the GUI rotate and this would be my solution but I think, its very inefficient to do:
1. double so much code in the richblocks even though only the type of item changes
2. loop all players every 2 seconds

options:
        richblocks: diamond block with name "&l&5open Crates!" with lore "&fYou own: %{crates.number.%loop-player%}%", emerald block with name "&l&5open Crates!" with lore "&fYou own: %{crates.number.%loop-player%}%" and gold block with name "&l&5open Crates!" with lore "&fYou own: %{crates.number.%loop-player%}%"
# . . . creating the GUI . . .
every 2 seconds:
    loop all players:
        if name of loop-player's current inventory is "&eC&dR&aA&bT&cE&3S":
            set slot 2 of loop-player's current inventory to random element of {@richblocks}

Do you have any solution to do this more efficient?

 

[DanRub]

Hey, I think you're the one I did the hopper script for. You can use the variable of the gui for the 2 seconds event, and you are chilling (You have to do global var on the previous one) and then add this:

on load:
    clear {richblocks::*}
    set {b1} to diamond block named "&l&5open Crates!" with lore "&fYou own: %{crates.number.%player%}%"
    set {b2} to emerald block named "&l&5open Crates!" with lore "&fYou own: %{crates.number.%player%}%"
    set {b3} to gold block named "&l&5open Crates!" with lore "&fYou own: %{crates.number.%player%}%"
    add {b1}, {b2} and {b3} to {richblocks::*}

every 2 seconds:
    set slot 2 of {crates.gui} to random element out of {richblocks::*}

 

[JuliHatSpaB]

Hey, I think you're the one I did the hopper script for. You can use the variable of the gui for the 2 seconds event, and you are chilling (You have to do global var on the previous one) and then add this:

on load:
    clear {richblocks::*}
    set {b1} to diamond block named "&l&5open Crates!" with lore "&fYou own: %{crates.number.%player%}%"
    set {b2} to emerald block named "&l&5open Crates!" with lore "&fYou own: %{crates.number.%player%}%"
    set {b3} to gold block named "&l&5open Crates!" with lore "&fYou own: %{crates.number.%player%}%"
    add {b1}, {b2} and {b3} to {richblocks::*}

every 2 seconds:
    set slot 2 of {crates.gui} to random element out of {richblocks::*}

Thank you. Yes I am the one with the hopper inventory. But it would be still every 2 seconds and isn't this really inefficent? Wouldn't my server lag if use this for too many GUIs?

 

[JuliHatSpaB]

And if the inventory is global, I could set the inventory one time and then just use the open {crates.gui} and delete the set slot ... right?

Hey, I think you're the one I did the hopper script for. You can use the variable of the gui for the 2 seconds event, and you are chilling (You have to do global var on the previous one) and then add this:

on load:
    clear {richblocks::*}
    set {b1} to diamond block named "&l&5open Crates!" with lore "&fYou own: %{crates.number.%player%}%"
    set {b2} to emerald block named "&l&5open Crates!" with lore "&fYou own: %{crates.number.%player%}%"
    set {b3} to gold block named "&l&5open Crates!" with lore "&fYou own: %{crates.number.%player%}%"
    add {b1}, {b2} and {b3} to {richblocks::*}

every 2 seconds:
    set slot 2 of {crates.gui} to random element out of {richblocks::*}

 

[DanRub]

Thank you. Yes I am the one with the hopper inventory. But it would be still every 2 seconds and isn't this really inefficent? Wouldn't my server lag if use this for too many GUIs?

It will definitely have less lag than running through every player on the server every 2 seconds

 

[DanRub]

And if the inventory is global, I could set the inventory one time and then just use the open {crates.gui} and delete the set slot ... right?

I don't know exactly what you mean right now, try to describe it a little bit.

 

[JuliHatSpaB]

I don't know exactly what you mean right now, try to describe it a little bit.

So I can change the original code:

command /crates:
    trigger:
        set {_crates.gui} to ...
        set slot 0 of {_crates.gui} to .....
        # set the other slots

to:

on load:
    set {crates.gui} to hopper...
    set slot 0 of {crates.gui} to .....
# set the other slots
command /crates:
    trigger:
        open {crates.gui} to player

 

[DanRub]

Ye, or you can do it through function, but its complicated