Effect on {OznaceniSmrti.%loop-player%}

[Barbarx]

VERSION: 1.11.2
SKRIPT VERSION: the newest
UMBASKA VERSION: the newest with all modules

effect dont work and dont know why. i think 14 -18 line. message dd is only testing if it works but didnt work.
please help me (

LINK: https://hastebin.com/rayotavahi.vbs

 

[Deleted member 5254]

This code is pretty bad; why the big "if victim is <this> or <this> or <this>" when you could just use else? Why damage something again in a damage event? It probably won't go through due to the invulnerability frames (or it will make the damage event's damage not go through for the same reason). Are you SURE that the OznaceniSmrti variable is set to true? How is it getting set to true?

The code could at least be cleaned up to look more like this, but it still probably won't solve your problem if you're not using and setting the variables correctly.

on damage:
    {OznaceniSmrti.%victim%} is true
    attacker is player
    if victim is player:
        damage the victim by 1
    else:
        damage the victim by 5
    wait 10 seconds
    if {OznaceniSmrti.%victim%} is true:
        set {OznaceniSmrti.%victim%} to false

every 10 ticks:
    loop all players:
        if {OznaceniSmrti.%loop-player%} is true:
            drawWarpRings style 1, particle "redstone", RGB 80, 255, 255, center location of block at player, id "%loop-player%-mark", rainbowMode true, scan true, height 2, radius 2, ringCount 40, ringDensity 20, visibleRange 32, pulseDelay 2

 

[Deleted member 5254]

i set OznaceniSmrti with this code.

on damage:
    if lore of tool of attacker contains "test2":
        chance of 100%:
            set {OznaceniSmrti.%victim%} to true
            message "&cByl jsi oznacen smrti" to victim
            message "&aOznacil si hrace" to attacker

and i will try you metode . and write if works.
And why i use or or or. because it works on armorstand if i use else:
and why i want to again damage entity? i wanna do bonus damage to player.
my bad i will use increase the damage by 1 and increase the damage by 5 to mobs.

 

[Deleted member 5254]

You don't need "chance of 100%" in that code (unless you're using it for debug and it is going to be lower when it's completed). If you want to make it do more damage and not affect armor stands, this should work:

on damage:
    {OznaceniSmrti.%victim%} is true
    attacker is player
    if victim is player:
        set damage to damage + 1
    else if "%victim%" isn't "armor stand":
        set damage to damage + 5
    wait 10 seconds
    if {OznaceniSmrti.%victim%} is true:
        set {OznaceniSmrti.%victim%} to false

every 10 ticks:
    loop all players:
        if {OznaceniSmrti.%loop-player%} is true:
            drawWarpRings style 1, particle "redstone", RGB 80, 255, 255, center location of block at player, id "%loop-player%-mark", rainbowMode true, scan true, height 2, radius 2, ringCount 40, ringDensity 20, visibleRange 32, pulseDelay 2

 

[Deleted member 5254]

yeah this works. but i still have problem with this

every 10 ticks:
    loop all players:
        if {OznaceniSmrti.%loop-player%} is true:
            drawWarpRings style 1, particle "redstone", RGB 80, 255, 255, center location of block at player, id "%loop-player%-mark", rainbowMode
true, scan true, height 2, radius 2, ringCount 40, ringDensity 20, visibleRange 32, pulseDelay 2

because it isnt work..

 

[Deleted member 5254]

You don't need to do a loop and constantly start the particles, you just need to start it once and use "center player" instead of "center location of block at player" and it should follow them forever.

 

[Deleted member 5254]

oh lol. thanks! works!