Solved Checking Name and Lore of item before using it

[ItsAlfiee]

Essentially, I'd like to make a Skript where if you have a certain item with a certain name and you right click it, it will give you certain potion effects. I got this working but I wanted to add a lore to the items showing what effects you get, and it stopped the code working. Please help me fix this code.

My code:

on rightclick:
    if player is holding slimeball named "&b&lJaw Breaker":
            apply swiftness 3 to the player for 10 seconds
            apply jump boost 4 to the player for 10 seconds
            remove 1 slimeball named "&b&lJaw Breaker" from player's inventory
            message "&a&l(*) &aYou consumed a Jaw Breaker!"

 

[Aidanete]

I don't know, because as you say it is used to work, but anyway:

What version of Skript are you using (Don't say latest)?

 

[ItsAlfiee]

I don't know, because as you say it is used to work, but anyway:

What version of Skript are you using (Don't say latest)?

The (sorry) but latest one from Bukkit. 2.1.2?

 

[Aidanete]

Hmm... This type of things should work in the version I use that is the last fork for Spigot, so I don't know how that things work in Bukkit 2.1.2

You probably should wait to another one with some more experience on this to check this out.

 

[ItsAlfiee]

Hmm... This type of things should work in the version I use that is the last fork for Spigot, so I don't know how that things work in Bukkit 2.1.2

You probably should wait to another one with some more experience on this to check this out.

Should it just stop working because there is a lore on it? Does Skript classify it as a different item?

 

[Aidanete]

Should it just stop working because there is a lore on it? Does Skript classify it as a different item?

Nope, it should work also with lore, because you're only detecting the name of the item, if it's the correct name, the lore is invariably on the final result.

 

[TPGamesNL]

You should install the latest version from Bensku's fork: https://github.com/SkriptLang/Skript/releases (edit: you might want dev-36 as dev-37 still has issues)

 

[ItsAlfiee]

You should install the latest version from Bensku's fork: https://github.com/SkriptLang/Skript/releases (edit: you might want dev-36 as dev-37 still has issues)

Did that, and got this

 

[TPGamesNL]

Try

if tool of player is slimeball named "&b&lJaw Breaker":

 

[FabricioSouza]

if player's held item is slimeball named "&b&lJaw Breaker" with lore "":

 

[ItsAlfiee]

if player's held item is slimeball named "&b&lJaw Breaker" with lore "":

I'll give it a try
[doublepost=1532016661,1532016505][/doublepost]

I'll give it a try

No luck @FabricoSouza

 

[FabricioSouza]

How so. It caught mine. It shows his addons to me.

 

[ShaneBee]

Hey @ItsAlfiee I tried this and it works

on rightclick:
    if player's tool is a slimeball:
        if name of player's tool contains "&b&lJaw Breaker":
            apply swiftness 3 to the player for 10 seconds
            apply jump boost 4 to the player for 10 seconds
            remove 1 of player's tool from player's inventory
            message "&a&l(*) &aYou consumed a Jaw Breaker!"

command /test:
    trigger:
        set {_jaw} to slimeball named "&b&lJaw Breaker"
        set 1st line of lore of {_jaw} to "&7Swiftness III"
        set 2nd line of lore of {_jaw} to "&7Jump Boost IV"
        give player 1 of {_jaw}

 

[TPGamesNL]

@ItsAlfiee can you check your aliases-english.sk for a slimeball. Also try replacing slimeball with something like stone to see if that works. You can also try removing the lore and name part.

 

[ShaneBee]

@ItsAlfiee can you check your aliases-english.sk for a slimeball. Also try replacing slimeball with something like stone to see if that works. You can also try removing the lore and name part.

the slimeball is the right item, i got it to work, but for some reason when you add lore to an item it wouldn't let me do "if name of players tool is" but if i do "if name of players tool contains" it works totally fine

 

[TPGamesNL]

the slimeball is the right item, i got it to work, but for some reason when you add lore to an item it wouldn't let me do "if name of players tool is" but if i do "if name of players tool contains" it works totally fine

I know the slimeball is the right item, but there could be something wrong with their aliases. And it seems that the "if name of tool of player is ..." should work, so you might want to report it on the issue tracker.

 

[ShaneBee]

Youre right I probably should
[doublepost=1532032866,1532032307][/doublepost]I just reported it ... THEN naturally after i report it,
I test it again, and it works either way, IS or CONTAINS... what the heck, that is odd!

 

[TPGamesNL]

Youre right I probably should
[doublepost=1532032866,1532032307][/doublepost]I just reported it ... THEN naturally after i report it,
I test it again, and it works either way, IS or CONTAINS... what the heck, that is odd!

Strange... Well glad it works now

 

[ItsAlfiee]

Sorry for a late reply, going to try all these methods tonight!
[doublepost=1532446271,1532445077][/doublepost]

Hey @ItsAlfiee I tried this and it works

on rightclick:
    if player's tool is a slimeball:
        if name of player's tool contains "&b&lJaw Breaker":
            apply swiftness 3 to the player for 10 seconds
            apply jump boost 4 to the player for 10 seconds
            remove 1 of player's tool from player's inventory
            message "&a&l(*) &aYou consumed a Jaw Breaker!"

command /test:
    trigger:
        set {_jaw} to slimeball named "&b&lJaw Breaker"
        set 1st line of lore of {_jaw} to "&7Swiftness III"
        set 2nd line of lore of {_jaw} to "&7Jump Boost IV"
        give player 1 of {_jaw}

This worked! Thanks a lot!

 

[ShaneBee]

Sorry for a late reply, going to try all these methods tonight!
[doublepost=1532446271,1532445077][/doublepost]

This worked! Thanks a lot!

You're welcome, glad I could help