Anvil lore change help

[Natulilakk]

im trying to make when you have 2 of the same lore in a anvil (Treasure Huter I + Treasure Huter I will become Treasure Huter II)

on anvil prepare:
if slot 0 of event-inventory is a netherite shovel:
if lore of slot 0 of event-inventory contains "&eTreasure Hunter I":
if slot 1 of event-inventory is a netherite shovel:
if lore of slot 1 of event-inventory contains "&eTreasure Hunter I":
if slot 2 of event-inventory is a netherite shovel:
if lore of slot 2 of event-inventory contains "&eTreasure Hunter I":
set {_itemlore} to slot 2 of event-inventory
set lore at line 1 of {_itemlore} to "TEXT"
play sound "entity.experience_orb.pickup" at volume 1 at pitch 1 at location(721, 83, 1090)

 

[Luke_Sky_Walker]

im trying to make when you have 2 of the same lore in a anvil (Treasure Huter I + Treasure Huter I will become Treasure Huter II)

on anvil prepare:
if slot 0 of event-inventory is a netherite shovel:
if lore of slot 0 of event-inventory contains "&eTreasure Hunter I":
if slot 1 of event-inventory is a netherite shovel:
if lore of slot 1 of event-inventory contains "&eTreasure Hunter I":
if slot 2 of event-inventory is a netherite shovel:
if lore of slot 2 of event-inventory contains "&eTreasure Hunter I":
set {_itemlore} to slot 2 of event-inventory
set lore at line 1 of {_itemlore} to "TEXT"
play sound "entity.experience_orb.pickup" at volume 1 at pitch 1 at location(721, 83, 1090)

Quite a few issues with your code. For the biggest issue, you don't have to check every single slot for the same item super long. You can set it as a separate variable. Also, since two pieces of your code check for the same item, you can check both slots at the same time. Finally, there's a much more simple way to set the lore. See the changes I made in the code I provided below. Longer code does not mean good code, thus why I shortened your code to 8 lines whilst still having it do its intended purpose (It also has no errors to my knowledge, not tested in game though):

Spoiler: Code Rework

on load:
    set {nshovel} to netherite shovel with lore "&eTreasure Hunter I" # Separately sets the target item to shorten next few lines
on anvil prepare:
    slot 0 and 1 of event-inventory is {nshovel} # We check both slot 0 and 1 at the same time to limit lines
    if slot 2 of event-inventory is {nshovel}:
        set {_i} to event-item # Sets {_i} to the target item
        set line 1 of lore of {_i} to "&eTreasure Hunter II" # Manually changes the item using the previously set variable
        play sound "entity.experience_orb.pickup" at volume 1 at pitch 1 at location(721, 83, 1090)

 

[Natulilakk]

It does not really work

 

[Luke_Sky_Walker]

It does not really work

Try rearranging the slot numbers in the code I wrote, I think one is setting up the lore's line improperly. It should be a relatively easy fix.

 

[Natulilakk]

unfortaly i dont really get it why it wont change the lore from Treasure Hunter I to Treasure Hunter II

 

[Natulilakk]

Yas i did it and all i needed to do was

on inventory click:
    if player's current inventory's type is anvil inventory:
        if slot 2 of event-inventory's lore is "&eTreasure Hunter I":
            clear lore of item
            set lore of item to "&eTreasure Hunter II"