I would expect your knowledge of Java to be much better then.
skUnity Forums
-
Welcome to skUnity!
Welcome to skUnity! This is a forum where members of the Skript community can communicate and interact. Skript Resource Creators can post their Resources for all to see and use.
If you haven't done so already, feel free to join our official Discord server to expand your level of interaction with the comminuty!
Now, what are you waiting for? Join the community now!
xXAndrew28Xx
LimeGlass
Explain then.
xXAndrew28Xx
I'll just go from what I see on Github right now, since you don't update it properly:
Oh boy, no type of system to check config for enabling syntaxes besides a hardcode
https://github.com/TheLimeGlass/Skellett/blob/master/SkellettGit/src/com/gmail/thelimeglass/Skellett.java
https://github.com/TheLimeGlass/Skellett/blob/master/SkellettGit/src/com/gmail/thelimeglass/Register.java
Oh boy, no type of system to check config for enabling syntaxes besides a hardcode
https://github.com/TheLimeGlass/Skellett/blob/master/SkellettGit/src/com/gmail/thelimeglass/Skellett.java
https://github.com/TheLimeGlass/Skellett/blob/master/SkellettGit/src/com/gmail/thelimeglass/Register.java
xXAndrew28Xx
That primitive thing in a discord channel recently, isn't that like one of the first things beginners should learn? A String is not a primitive.
Non-standard package naming
Bragging about how much work has been done by showing how many classes you have made when that amount is relatively low to what I have seen possible in 6 months
Non-standard package naming
Bragging about how much work has been done by showing how many classes you have made when that amount is relatively low to what I have seen possible in 6 months
xXAndrew28Xx
Ever heard of the ternary operator, or tried using it? I heard its quite easy.
https://github.com/TheLimeGlass/Skellett/blob/master/SkellettGit/src/com/gmail/thelimeglass/Tablist/EffNewTabItem.java
https://github.com/TheLimeGlass/Skellett/blob/master/SkellettGit/src/com/gmail/thelimeglass/Stylishboards/CondStylishExists.java
https://github.com/TheLimeGlass/Skellett/blob/master/SkellettGit/src/com/gmail/thelimeglass/Tablist/EffNewTabItem.java
https://github.com/TheLimeGlass/Skellett/blob/master/SkellettGit/src/com/gmail/thelimeglass/Stylishboards/CondStylishExists.java
xXAndrew28Xx
https://github.com/TheLimeGlass/Skellett/blob/master/SkellettGit/src/com/gmail/thelimeglass/SkellettProxy/CondOnlinePlayer.java#L52-L56
Unneeded else and return
https://github.com/TheLimeGlass/Skellett/blob/master/SkellettGit/src/com/gmail/thelimeglass/Tablist/EffDeleteTabItem.java#L39
just keep calling getSingle instead of putting it in to a variable. What is this thing called performance?
Unneeded else and return
https://github.com/TheLimeGlass/Skellett/blob/master/SkellettGit/src/com/gmail/thelimeglass/Tablist/EffDeleteTabItem.java#L39
just keep calling getSingle instead of putting it in to a variable. What is this thing called performance?
xXAndrew28Xx
Hmm, error on invalid something? The answer totally is to not handle it and just put an empty try catch!
Haha, && operator? Whats that
A lot of other small things I won't nitpick about.
If any of these files were made a while ago, I wasn't sure because _someone_ couldn't use git properly though million of other repositiories figured out how.
Haha, && operator? Whats that
A lot of other small things I won't nitpick about.
If any of these files were made a while ago, I wasn't sure because _someone_ couldn't use git properly though million of other repositiories figured out how.
LimeGlass
I know about ternary operator's. I just don't like them.
I have registered enum types to handle annotation types.
What are you talking about no check for config?
I have registered enum types to handle annotation types.
What are you talking about no check for config?
xXAndrew28Xx
I don't know about your reading skills but:
"Oh boy, no type of system to check config for enabling syntaxes besides a hardcode"
"Oh boy, no type of system to check config for enabling syntaxes besides a hardcode"
LimeGlass
The Uneeded else return is actually important as SkellettProxy determines it's output.
It either returns a player or uuid based on the users input of the string.
It either returns a player or uuid based on the users input of the string.
xXAndrew28Xx
It literally does nothing.
Edit: Also another case of you completely ignoring something? I was talking about a class that was for TabListAPI.
Edit: Also another case of you completely ignoring something? I was talking about a class that was for TabListAPI.
LimeGlass
The && operator is called Logical AND operator. If both the operands are non-zero, then the condition becomes true. You can find more info on it here https://www.tutorialspoint.com/java/java_basic_operators.htm
xXAndrew28Xx
Well if you know what it is, it might be beneficial to use it in some places where you have two if clauses nested without any elses.