Help with shop skript

[Ceravia]

This give me no errors, my economy script can be added, subtracted, etc. So my economy is parsed correctly but these functions don't do anything. I can pull up the GUI with lore but nothing in it works. Running 2.2 fixes v8b

function purchaseItem(p: Player, cost: integer, i: item):
    if {bean.money.%{_p}%} >= {_cost}:
        remove {_cost} parsed as integer from {bean.money.%{_p}%}
        give {_item} parsed as item to {_p}
    else:
        broadcast "{@p}You cannot afford this item!"
function sellItem(p: Player, earn: integer, i: item):
    if {_p} has {_item}:
        remove {_item} from {_p}'s inventory
        add {_earn} to {bean.money.%{_p}%}   
    
on rightclick on villager:
    cancel event
    if name of player's target entity contains "&aBlacksmith":
        wait 1 tick
        open virtual chest inventory with size 6 named "&aShop" to player
        wait 1 tick
        set {_diamondHelm} to diamond helmet
        set line 1 of lore of {_diamondHelm} to "&eLeft click to &aBuy 1"
        set line 2 of lore of {_diamondHelm} to "&eCosts &f$2500"
        set line 3 of lore of {_diamondHelm} to "&cRight click &aSell 1"
        set line 4 of lore of {_diamondHelm} to "&eEarns &f$1250"
        format gui slot 0 of player with {_diamondHelm} to run function purchaseItem(player, 2500, diamond helmet) with "left" click
        format gui slot 0 of player with {_diamondHelm} to run function sellItem(player, 1250, diamond helmet) with "right" click

 

[ShaneBee]

Any error? I would say change "item" on functions to "item type" or "material" but im not sure. if that fix your problem please mark as solved

 

[ShaneBee]

Any error? I would say change "item" on functions to "item type" or "material" but im not sure. if that fix your problem please mark as solved

No errors, changing to item and type and material also did not work

 

[ShaneBee]

This give me no errors, my economy script can be added, subtracted, etc. So my economy is parsed correctly but these functions don't do anything. I can pull up the GUI with lore but nothing in it works. Running 2.2 fixes v8b

function purchaseItem(p: Player, cost: integer, i: item):
    if {bean.money.%{_p}%} >= {_cost}:
        remove {_cost} parsed as integer from {bean.money.%{_p}%}
        give {_item} parsed as item to {_p}
    else:
        broadcast "{@p}You cannot afford this item!"
function sellItem(p: Player, earn: integer, i: item):
    if {_p} has {_item}:
        remove {_item} from {_p}'s inventory
        add {_earn} to {bean.money.%{_p}%}  
   
on rightclick on villager:
    cancel event
    if name of player's target entity contains "&aBlacksmith":
        wait 1 tick
        open virtual chest inventory with size 6 named "&aShop" to player
        wait 1 tick
        set {_diamondHelm} to diamond helmet
        set line 1 of lore of {_diamondHelm} to "&eLeft click to &aBuy 1"
        set line 2 of lore of {_diamondHelm} to "&eCosts &f$2500"
        set line 3 of lore of {_diamondHelm} to "&cRight click &aSell 1"
        set line 4 of lore of {_diamondHelm} to "&eEarns &f$1250"
        format gui slot 0 of player with {_diamondHelm} to run function purchaseItem(player, 2500, diamond helmet) with "left" click
        format gui slot 0 of player with {_diamondHelm} to run function sellItem(player, 1250, diamond helmet) with "right" click

Setting an item to a variable and giving/taking the variable doesn't work (its never worked for me atleast... idk if someone knows a way around it)

 

[ShaneBee]

This is working: Change item type to string and parse it when u are trying to give the item

on load:
    set {item} to "diamond sword"

function test2(p: player):
    give ("%{item}%" parsed as item type) to {_p}

Please mark as solved if it fixed ur problem.

 

[ShaneBee]

This is working: Change item type to string and parse it when u are trying to give the item

on load:
    set {item} to "diamond sword"

function test2(p: player):
    give ("%{item}%" parsed as item type) to {_p}

Please mark as solved if it fixed ur problem.

The issues is he's using the wrong variable names in the function. @Op you should be using the names not the types

 

[ShaneBee]

The issues is he's using the wrong variable names in the function. @Op you should be using the names not the types

I'm not quite sure what you mean :/. Sorry I'm still learning script and this is my first time dealing with functions.

 

[ShaneBee]

I'm not quite sure what you mean :/. Sorry I'm still learning script and this is my first time dealing with functions.

function purchaseItem(p: Player, cost: integer, i: item):

give {_item} parsed as item to {_p}

This should be {_i} not {_item}

Same at SellItem

 

[ShaneBee]

This should be {_i} not {_item}

Same at SellItem

That seems to be an issue and I have fixed it, but it still isn't working. Also, the script is not negating or adding money to my balance. Perhaps the entire function isn't even playing?