Solved Fishing (Small Script)

[IDuckz_]

So um I have been trying to make it whenever a player catches a fish, it'll execute this like of code: send "hi" to player, but It did not execute it, any ideas to fix this? (Also please do not judge my code )

Plugins I am using: Skript (Obviously), SkQuery, Skellet, SkNBeeT, TuSKe, and SkRayFall

Here is my code:

on fishing:
    if player is holding a fishing rod named "&bNovice Rod":
        if "%fishing state%" is "CAUGHT_FISH":
            chance of 50%:
                send "hi" to player
                stop
            chance of 50%:
                send "bye" to player
                stop

Thanks

 

[TheCringleYT]

Try this:

on fishing:
    if player is holding a fishing rod named "&bNovice Rod":
        wait 5 seconds
        set {fishing.done} to true
        chance of 50%:
            send "Hi" to player
        set {fishing.done} to false
            stop
        chance of 50%:
            send "Bye" to player
        set {fishing.done} to false
            stop

 

[TPGamesNL]

So um I have been trying to make it whenever a player catches a fish, it'll execute this like of code: send "hi" to player, but It did not execute it, any ideas to fix this? (Also please do not judge my code )

Plugins I am using: Skript (Obviously), SkQuery, Skellet, SkNBeeT, TuSKe, and SkRayFall

Here is my code:

on fishing:
    if player is holding a fishing rod named "&bNovice Rod":
        if "%fishing state%" is "CAUGHT_FISH":
            chance of 50%:
                send "hi" to player
                stop
            chance of 50%:
                send "bye" to player
                stop

Thanks

You should probably add some debug message before your conditions, to see which code does get executed and which code doesn't.

 

[IDuckz_]

It seems this part: if "%fishing state%" is "CAUGHT_FISH":

Also TheCringeYT, you are only using 1 variable {fishing.done}, what if multiple players are fishing? So I don't think its going to work.

 

[TPGamesNL]

It seems this part: if "%fishing state%" is "CAUGHT_FISH":

Also TheCringeYT, you are only using 1 variable {fishing.done}, what if multiple players are fishing? So I don't think its going to work.

You should add a debug message for `fishing state`, to see if you're using the right comparison

 

[IDuckz_]

Nevermind I got it working, thanks for the help.