Need help with offhand potion effects

[Duck]

Hi, so I made a script for holding a specific item in your offhand and it gives potion effects. This works in with 1 or 2 people, but when tried on a whole server, there was a ton of lag. Any help?

on inventory close:
    while player is online:
        loop all players:
            if player's offhand tool is flint named "&6Test":
                remove strength from player
                apply strength 1 to player for 5 seconds
        wait 5 seconds

Please help

 

[Iroh]

i'd use something like this maybe?

every 5 seconds in "world":
  loop all players:     
    if player's offhand tool is flint named "&6Test":
      apply strength 1 to player for 5 seconds

also you might want to consider an offhand attack damage attribute instead for strength so you don't have to deal with potion effects. but that's just my opinion

 

[Mich]

Hi, so I made a script for holding a specific item in your offhand and it gives potion effects. This works in with 1 or 2 people, but when tried on a whole server, there was a ton of lag. Any help?

on inventory close:
    while player is online:
        loop all players:
            if player's offhand tool is flint named "&6Test":
                remove strength from player
                apply strength 1 to player for 5 seconds
        wait 5 seconds

Please help

try this

on swap hand item:
    if player's offhand tool is flint named "&6Test":
        remove strength from player
        apply strength 1 to player for 5 seconds
        wait 5 seconds
    else if player's offhand tool is flint named "&6Test": #other item
        #code
    else: #when player item is not a special item
        #code, example remove potions effects or nothing since the effect last 5 seconds you just can remove this else

[doublepost=1649810038,1649809975][/doublepost]

i'd use something like this maybe?

every 5 seconds in "world":
  loop all players:   
    if player's offhand tool is flint named "&6Test":
      apply strength 1 to player for 5 seconds

also you might want to consider an offhand attack damage attribute instead for strength so you don't have to deal with potion effects. but that's just my opinion

this is a good one because the other code is creating a while loop for everyone every time someone opens the inventory