Solved Improving my Skript

[iMinePixels]

Hello, I am really new to skript. I made a money voucher to grant a random amount of money, that I set, but I feel like the way that I did it, isn't safe, or may bug out.

As of now, it works flawlessly, but again, feels unsafe. Could I get some help making this more safe? i doubt if this will be okay to use on a live server?

Edit 1: I only made it "if player's tool's display name is "&a&lᴍᴏɴᴇʏ ᴘᴏᴜᴄʜ &8(&7Tier-1&8)":" because no one on the server will be able to rename items with color, so ultimately, only those who have the item can only right-click it for the skript to run. They cannot produce an item with the same colors and format.

on rightclick:
    if player's tool is a paper:
        if player's tool's display name is "&a&lᴍᴏɴᴇʏ ᴘᴏᴜᴄʜ &8(&7Tier-1&8)":
            cancel the event
            remove 1 of player's tool from player's inventory
            set {_amount} to a random integer between 500 and 10000
            execute console command "eco give %player% %{_amount}%"

 

[BaeFell]

I'd still be careful with adding colour codes. Could still be faked by someone, although can't remember if anvils let you put & in.

If you've got Vault installed, you can do add {_amount} to balance of player

 

[iMinePixels]

I'd still be careful with adding colour codes. Could still be faked by someone, although can't remember if anvils let you put & in.

If you've got Vault installed, you can do add {_amount} to balance of player

I don't think anvils do that on java. I recall seeing multiple plugins make anvils do that though.

I can switch out the execute line for what you said, thank you.

This is what it looks like if a player renames a paper to exactly that the item's name is. Which when they do that, no longer is right-clickable.

 

[brsko]

I don't think anvils do that on java. I recall seeing multiple plugins make anvils do that though.

I can switch out the execute line for what you said, thank you.

This is what it looks like if a player renames a paper to exactly that the item's name is. Which when they do that, no longer is right-clickable.

View attachment 8373

With the colour codes, if you have EssentialsX installed you can use /iname for colours.

 

[NixTer]

He does have essentials installed (you can tell from the eco give command) but also /iname requires a specific permission, so not applicable in this instance.

 

[iMinePixels]

He does have essentials installed (you can tell from the eco give command) but also /iname requires a specific permission, so not applicable in this instance.

Exactly this, I do not plan to give anyone access to the item rename command or any other ability to create this formatted name. I guess imma just consider this solved, if something comes up, ill make a new post. Thank you everyone.