Element of a list variable

[iChinchillinq]

I'm making a Cards Against Humanity skript atm, and all of the "second, third, fourth, etc" elements aren't working. However, the first element works.

                if argument 1 is "pick":
                    if argument 2 is not set:
                        send "&5CAH &8» &fPlease pick a valid card. (Numbers 1-10)"
                    else:
                        if argument 2 is "1" or "2" or "3" or "4" or "5" or "6" or "7" or "8" or "9" or "10":                         
                            set {picked.%player%} to argument 2
                            if argument 2 is "1":
                                set {card.%player%} to the first element of {cards.%player%::*}
                            if argument 2 is "2":
                                set {card.%player%} to the second element of {cards.%player%::*}
                            if argument 2 is "3":
                                set {card.%player%} to the third element of {cards.%player%::*}
                            if argument 2 is "4":
                                set {card.%player%} to the fourth element of {cards.%player%::*}
                            if argument 2 is "5":
                                set {card.%player%} to the fifth element of {cards.%player%::*}
                            if argument 2 is "6":
                                set {card.%player%} to the sixth element of {cards.%player%::*}
                            if argument 2 is "7":
                                set {card.%player%} to the seventh element of {cards.%player%::*}
                            if argument 2 is "8":
                                set {card.%player%} to the eighth element of {cards.%player%::*}
                            if argument 2 is "9":
                                set {card.%player%} to the ninth element of {cards.%player%::*}
                            if argument 2 is "10":
                                set {card.%player%} to the tenth element of {cards.%player%::*}
                            send "&5CAH &8» &fPicked card &d%{picked.%player%}%&f.%nl%&f(%{card.%player%}%)"

Errors: http://prntscr.com/k98g8s

 

[FinalPlayer024]

I think you could also use

{cards.%player%::%arg 2%}

Like

arg 2 is not set:

  send "&5CAH &8» &fPlease pick a valid card. (Numbers 1-10)"
  stop

arg 2 = "1" or "2" or "3" or "4" or "5" or "6" or "7" or "8" or "9" or "10"
send "&5CAH &8» &fPicked card &d%arg 2%&f.%nl%&f(%{cards.%player%::%arg 2%}%)"

 

[Efnilite]

I think you could also use

{cards.%player%::%arg 2%}

Like

arg 2 is not set:

  send "&5CAH &8» &fPlease pick a valid card. (Numbers 1-10)"
  stop

arg 2 = "1" or "2" or "3" or "4" or "5" or "6" or "7" or "8" or "9" or "10"
send "&5CAH &8» &fPicked card &d%arg 2%&f.%nl%&f(%{cards.%player%::%arg 2%}%)"

1. Use list variables (replace all ' . ' with ' :: '), its a way easier/clean way to save vars

2. Use else if after an if, like this: (Less laggy)

if arg-1 = "1":
    send "1"
else if arg-1 = "2":
    send "2"

And @FinalPlayer024 is right, since it's better to use {cards::%player%::4}

Full code:

                if arg-1 is "pick":
                    if arg-2 is not set:
                        send "&5CAH &8» &fPlease pick a valid card. (Numbers 1-10)"
                    else:
                        if arg-2 is "1" or "2" or "3" or "4" or "5" or "6" or "7" or "8" or "9" or "10":                    
                            set {picked::%player%} to arg-2
                            set {card::%player%} to {cards::%player%::%arg-2%}
                            send "&5CAH &8» &fPicked card &d%{picked::%player%}%&f.%nl%&f(%{card::%player%}%)"

 

[TPGamesNL]

1. Use list variables (replace all ' . ' with ' :: '), its a way easier/clean way to save vars

2. Use else if after an if, like this: (Less laggy)

if arg-1 = "1":
    send "1"
else if arg-1 = "2":
    send "2"

And @FinalPlayer024 is right, since it's better to use {cards::%player%::4}

Full code:

                if arg-1 is "pick":
                    if arg-2 is not set:
                        send "&5CAH &8» &fPlease pick a valid card. (Numbers 1-10)"
                    else:
                        if arg-2 is "1" or "2" or "3" or "4" or "5" or "6" or "7" or "8" or "9" or "10":                      
                            set {picked::%player%} to arg-2
                            if arg-2 is "1":
                                set {card::%player%} to {cards::%player%::1}
                            else if arg-2 is "2":
                                set {card::%player%} to {cards::%player%::2}
                            else if arg-2 is "3":
                                set {card::%player%} to {cards::%player%::3}
                            else if arg-2 is "4":
                                set {card::%player%} to {cards::%player%::4}
                            else if arg-2 is "5":
                                set {card::%player%} to {cards::%player%::5}
                            else if arg-2 is "6":
                                set {card::%player%} to {cards::%player%::6}
                            else if arg-2 is "7":
                                set {card::%player%} to {cards::%player%::7}
                            else if arg-2 is "8":
                                set {card::%player%} to {cards::%player%::8}
                            else if arg-2 is "9":
                                set {card::%player%} to {cards::%player%::9}
                            else if arg-2 is "10":
                                set {card::%player%} to {cards::%player%::10}
                            send "&5CAH &8» &fPicked card &d%{picked::%player%}%&f.%nl%&f(%{card::%player%}%)"

Look at the code again. It can be done much easier...

 

[Donut]

for future reference to get the nth element of a list (besides first/last) you have to use the number like 3rd, 4th, 5th, 80th, 100th as the syntax is

([the] first|[the] last|[a] random|%number%(st|nd|rd|th)) element [out] of %objects%

 

[Efnilite]

Look at the code again. It can be done much easier...

Yeah im blind, fixed it