Solved Better detection for a certain string.

[Farid]

I was trying to block certain commands. I was having issues with on command event, however PlayerCommandPreProcessis amazing and fires really fast. I was wondering if there is a way to detect if there is an argument after the command is fired. This code below works however, it doesn't work when there is an argument into the command, for example /pl s would fire the command.

on script load:
    add "/sk" to {blockedcmd::*}
    add "/skript" to {blockedcmd::*}
    add "/bukkit:help" to {blockedcmd::*}
    add "/bukkit:ver" to {blockedcmd::*}
    add "/ver" to {blockedcmd::*}
    add "/version" to {blockedcmd::*}
    add "/about" to {blockedcmd::*}
    add "/bukkit:about" to {blockedcmd::*}
    add "//calc" to {blockedcmd::*}
    add "//eval" to {blockedcmd::*}
    add "//calculate" to {blockedcmd::*}
    add "//evaluate" to {blockedcmd::*}
    add "/pl" to {blockedcmd::*}
    add "/plugins" to {blockedcmd::*}
    add "/bukkit:pl" to {blockedcmd::*}
    add "/?" to {blockedcmd::*}
    add "/bukkit:?" to {blockedcmd::*}

on "org.bukkit.event.player.PlayerCommandPreprocessEvent":
    loop {blockedcmd::*}:
        if loop-value.contains(event.getMessage().toLowerCase().toString()) = true:
            if getGroup(event.getPlayer()) isn't "Owner" or "Developer":
                send "&c&l(!) &eCommand was not found!" to event.getPlayer()
                event.setCancelled(true)

 

[Donut]

on "org.bukkit.event.player.PlayerCommandPreprocessEvent":
    if {blockedcmd::*} contains first element of event.getMessage() split at " ":
        if getGroup(event.getPlayer()) isn't "Owner" or "Developer":
            send "&c&l(!) &eCommand was not found!" to event.getPlayer()
            cancel event

 

[Farid]

on "org.bukkit.event.player.PlayerCommandPreprocessEvent":
    if {blockedcmd::*} contains first element of event.getMessage() split at " ":
        if getGroup(event.getPlayer()) isn't "Owner" or "Developer":
            send "&c&l(!) &eCommand was not found!" to event.getPlayer()
            cancel event

Thanks for the response! The code didn't seem to work, so I debugged and found out that it's not going through, hence I'm not getting the message 1 at all.

on "org.bukkit.event.player.PlayerCommandPreprocessEvent":
    if {blockedcmd::*} contains first element of event.getMessage() split at " ":
        send "1" to event.getPlayer()
        if getGroups(event.getPlayer()) doesn't contain "Owner" or "Developer":
            send "2" to event.getPlayer()
            send "&c&l(!) &eCommand was not found!" to event.getPlayer()
            event.setCancelled(true)

 

[Donut]

what skript ver? contains on variables was fixed in dev35

 

[Farid]

what skript ver? contains on variables was fixed in dev35

Paperspigpt 1.8.8 (Probably why, some features disabled in 1.8.8)
Skript-2.2-dev37c
skript-mirror 0.16.1

 

[Donut]

this is what i tested with and it works fine

on "org.bukkit.event.player.PlayerCommandPreprocessEvent":
    set {blockedcmd::*} to "/test"
    if {blockedcmd::*} contains first element of event.getMessage() split at " ":
        if getGroup(event.getPlayer()) isn't "Owner" or "Developer":
            send "&c&l(!) &eCommand was not found!" to event.getPlayer()
            cancel event

 

[Farid]

this is what i tested with and it works fine

on "org.bukkit.event.player.PlayerCommandPreprocessEvent":
    set {blockedcmd::*} to "/test"
    if {blockedcmd::*} contains first element of event.getMessage() split at " ":
        if getGroup(event.getPlayer()) isn't "Owner" or "Developer":
            send "&c&l(!) &eCommand was not found!" to event.getPlayer()
            cancel event

That didn't work, but this did.

on "org.bukkit.event.player.PlayerCommandPreprocessEvent":
    set {_s::*} to event.getMessage() split at " "
    loop {_s::*}:
        if contains({blockedcmd::*}, loop-value) = true:
            if getGroups(event.getPlayer()) doesn't contain "Owner" or "Developer":
                send "&c&l(!) &eCommand was not found!" to event.getPlayer()
                event.setCancelled(true)

function contains(list: objects, check: object) :: boolean:
    loop {_list::*}:
        if loop-value is {_check}:
            return true
    return false