Fish aren't custom

[SuperTommyDog]

So i am making a custom fishing element for my server and i get normal vanilla fish and items not my custom ones even after i made this

on fish:
    if "%fishing state%" is "CAUGHT_FISH":
        if name of player's tool contains "&7Basic Rod":
            stop
            set {_size} to a random integer between 1 and 20
            set {_fish} to a random integer between 1 and 5
            if {_fish} is 1:
                give player 1 raw_fish named "&aAtlantic cod" with lore "&7%{_size}% Inches"
            if {_fish} is 2:
                give player 1 raw_fish named "&aPacific cod" with lore "&7%{_size}% Inches"
            if {_fish} is 3:
                give player 1 salmon named "&bAtlantic Salmon" with lore "&7%{_size}% Inches"
            if {_fish} is 4:
                give player 1 salmon named "&bPacific Salmon" with lore "&7%{_size}% Inches"
            if {_fish} is 5:
                give player 1 salmon named "&cHaddock" with lore "&7%{_size}% Inches"

do you have any idea why? There are 0 errors

 

[couger44]

So i am making a custom fishing element for my server and i get normal vanilla fish not my custom one even after i made this

on fish:
    if "%fishing state%" is "CAUGHT_FISH":
        if name of player's tool contains "&7Basic Rod":
            stop
            set {_size} to a random integer between 1 and 20
            set {_fish} to a random integer between 1 and 5
            if {_fish} is 1:
                give player 1 raw_fish named "&aAtlantic cod" with lore "&7%{_size}% Inches"
            if {_fish} is 2:
                give player 1 raw_fish named "&aPacific cod" with lore "&7%{_size}% Inches"
            if {_fish} is 3:
                give player 1 salmon named "&bAtlantic Salmon" with lore "&7%{_size}% Inches"
            if {_fish} is 4:
                give player 1 salmon named "&bPacific Salmon" with lore "&7%{_size}% Inches"
            if {_fish} is 5:
                give player 1 salmon named "&cHaddock" with lore "&7%{_size}% Inches"

do you have any idea why? There are 0 errors

?

Try putting the 'stop' at the end of the code.

 

[SuperTommyDog]

Sorry for the late reply i have been busy, but putting stop at the end gives me both (custom and vanilla) which i don't want

 

[couger44]

Sorry for the late reply i have been busy, but putting stop at the end gives me both (custom and vanilla) which i don't want

It depends on where you put the 'stop', try putting it here:

on fish:
    if "%fishing state%" is "CAUGHT_FISH":
        if name of player's tool contains "&7Basic Rod":
            set {_size} to a random integer between 1 and 20
            set {_fish} to a random integer between 1 and 5
            if {_fish} is 1:
                give player 1 raw_fish named "&aAtlantic cod" with lore "&7%{_size}% Inches"
            if {_fish} is 2:
                give player 1 raw_fish named "&aPacific cod" with lore "&7%{_size}% Inches"
            if {_fish} is 3:
                give player 1 salmon named "&bAtlantic Salmon" with lore "&7%{_size}% Inches"
            if {_fish} is 4:
                give player 1 salmon named "&bPacific Salmon" with lore "&7%{_size}% Inches"
            if {_fish} is 5:
                give player 1 salmon named "&cHaddock" with lore "&7%{_size}% Inches"
            stop # < - - -

 

[Lego_freak1999]

Replace stop with cancel event

 

[IDuckz_]

^ Also if you do not want to cancel event, then it's useless having a stop there.